Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, there is one more inconsistency in the build systems that I'd like to sync.
I've left this one as the last "HAVE_* symbols sync" in the PHP-8.4-dev branch (hopefully it is the last for the time being). These symbols are very error prone defined in the form of
HAVE_<extension>
but I'll leave this be for now.So, now we have for the ext/openssl the
HAVE_OPENSSL
defined to 1 on Windows, andHAVE_OPENSSL_EXT
defined to 1 on both. On Windows theHAVE_OPENSSL_EXT
is additionally defined to value 0 if the ext/openssl is built as shared. From my point of view this is not consistent and doesn't make much sense to be practical in extensions. Although, I understand the motivation of 0 and 1 value.My suggestion here would be:
HAVE_OPENSSL_EXT
in the same style on both systems (undefined - extension is not available, defined to 1 - extension is available)HAVE_OPENSSL
as it was only defined on Windows and it was in the past defined also elsewhereI've quickly scanned the PECL community open source extensions and so far only oath is using this HAVE_OPENSSL_EXT symbol with
#if HAVE_OPENSSL_EXT
, which can be resolved quite simple. I'll also recheck the extensions again but it doesn't seem to be problematic.Your thoughts are welcome. Thanks.